linux-kernel - Re: [PATCH] xen: ifdef CONFIG_HIBERNATE_CALLBACKS xen_*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51CC9C35.6090901@oracle.com>
Date:	Thu, 27 Jun 2013 16:10:29 -0400
From:	konrad wilk <konrad.wilk@...cle.com>
To:	Stefano Stabellini <stefano.stabellini@...citrix.com>
CC:	linux-kernel@...r.kernel.org, stefano.stabellini@...rix.com,
	xen-devel@...ts.xen.org
Subject: Re: [PATCH] xen: ifdef CONFIG_HIBERNATE_CALLBACKS xen_*_suspend


On 6/27/2013 9:28 AM, Stefano Stabellini wrote:
> xen_hvm_post_suspend, xen_pre_suspend, xen_post_suspend are only used if
> CONFIG_HIBERNATE_CALLBACKS is defined, resulting in:
>
> drivers/xen/manage.c:46:13: warning: ‘xen_hvm_post_suspend’ defined but not used [-Wunused-function]
> drivers/xen/manage.c:52:13: warning: ‘xen_pre_suspend’ defined but not used [-Wunused-function]
> drivers/xen/manage.c:59:13: warning: ‘xen_post_suspend’ defined but not used [-Wunused-function]
>
> If the kernel config is missing CONFIG_HIBERNATE_CALLBACKS.
>
> Simply ifdef CONFIG_HIBERNATE_CALLBACKS the three functions.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@...citrix.com>
> ---
>   drivers/xen/manage.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
> index 412b96c..b1005d4 100644
> --- a/drivers/xen/manage.c
> +++ b/drivers/xen/manage.c
> @@ -43,6 +43,7 @@ struct suspend_info {
>   	void (*post)(int cancelled);
>   };
>   
> +#ifdef CONFIG_HIBERNATE_CALLBACKS
>   static void xen_hvm_post_suspend(int cancelled)
>   {
>   	xen_arch_hvm_post_suspend(cancelled);
> @@ -63,7 +64,6 @@ static void xen_post_suspend(int cancelled)
>   	xen_mm_unpin_all();
>   }
>   
> -#ifdef CONFIG_HIBERNATE_CALLBACKS
>   static int xen_suspend(void *data)
>   {
>   	struct suspend_info *si = data;
Looks ok. Will queue it up for 3.11

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/