linux-kernel - Re: [PATCH v3 4/4] watchdog: Kontron PLD watchdog timer driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130627220556.GB16090@wrk>
Date:	Thu, 27 Jun 2013 15:05:56 -0700
From:	Kevin Strasser <kevin.strasser@...ux.intel.com>
To:	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	Wim Van Sebroeck <wim@...ana.be>,
	Kevin Strasser <strassek@...r.orst.edu>,
	Darren Hart <dvhart@...ux.intel.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Michael Brunner <Michael.Brunner@...tron.com>,
	Michael Brunner <mibru@....de>,
	Chris Healy <chealy@...co-us.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Dirk Hohndel <Dirk.Hohndel@...el.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Ben Dooks <ben-linux@...ff.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/4] watchdog: Kontron PLD watchdog timer driver

Hi Samuel,

On Thu, Jun 27, 2013 at 11:47:05PM +0200, Samuel Ortiz wrote:
> Hi Kevin,
> 
> On Thu, Jun 27, 2013 at 11:23:15AM -0700, Kevin Strasser wrote:
> > Hi Wim,
> > 
> > This driver hasn't received any further feedback. Are you ready to take it
> > into watchdog-next, or do you still need to review it?
> I applied the watchdog patch to mfd-next and got the following warning:
> 
>  CC [M]  drivers/watchdog/kempld_wdt.o
> drivers/watchdog/kempld_wdt.c: In function ‘kempld_wdt_suspend’:
> drivers/watchdog/kempld_wdt.c:538:3: warning: passing argument 1 of
> ‘kempld_wdt_stop’ from incompatible pointer type [enabled by default]
> drivers/watchdog/kempld_wdt.c:313:12: note: expected ‘struct
> watchdog_device *’ but argument is of type ‘struct platform_device *’
> 
> I fixed it up, but I'd appreciate if you could double check that
> kempld_wdt_suspend() is ok.

Ah, yes you made the appropriate change. This used to be a call to 
kempld_wdt_shutdown, which I changed to kempld_wdt_stop to avoid the
pointless redirection. Somehow I forgot to convert the argument.

Thanks,
Kevin

> 
> Cheers,
> Samuel.
> 
> -- 
> Intel Open Source Technology Centre
> http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/