lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 28 Jun 2013 09:31:05 +0200 From: Lukasz Majewski <l.majewski@...sung.com> To: Viresh Kumar <viresh.kumar@...aro.org> Cc: "Rafael J. Wysocky" <rjw@...k.pl>, "cpufreq@...r.kernel.org" <cpufreq@...r.kernel.org>, Linux PM list <linux-pm@...r.kernel.org>, Vincent Guittot <vincent.guittot@...aro.org>, Jonghwa Lee <jonghwa3.lee@...sung.com>, Myungjoo Ham <myungjoo.ham@...sung.com>, linux-kernel <linux-kernel@...r.kernel.org>, Lukasz Majewski <l.majewski@...ess.pl>, Andre Przywara <andre.przywara@...aro.org>, Daniel Lezcano <daniel.lezcano@...aro.org>, Kukjin Kim <kgene.kim@...sung.com>, Zhang Rui <rui.zhang@...el.com>, Eduardo Valentin <eduardo.valentin@...com> Subject: Re: [PATCH v4 2/7] cpufreq: Add boost frequency support in core On Fri, 28 Jun 2013 12:21:21 +0530, Viresh Kumar wrote: > On 28 June 2013 12:19, Lukasz Majewski <l.majewski@...sung.com> wrote: > > No, I will use: > > > > if (boost_enabled != state) { > > write_lock_irqsave(&cpufreq_driver_lock, flags); > > boost_enabled = state; > > > > ret = cpufreq_driver->enable_boost(state); > > ^^^^^^^^^^^^^^^^^^^^ only one callback call > > if (ret) > > boost_enabled = 0; > > > > write_unlock_irqrestore(&cpufreq_driver_lock, flags); > > > > if (ret) > > pr_err("%s: BOOST cannot enable (%d)\n", > > __func__, ret); > > } > > > > and @ cpufreq_register_driver() I will add following line: > > > > if (!cpufreq_driver->enable_boost) > > cpufreq_driver->enable_boost = &cpufreq_boost_enable_sw; > > > > When cpufreq driver doesn't define callback for enable_boost it > > will be filled with default SW cpufreq_boost_enable_sw callback. > > That's some smart code. Good. :) OK -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists