linux-kernel - Re: [PATCH] x86: Fix override new_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130628005642.GA2232@udknight>
Date:	Fri, 28 Jun 2013 08:56:42 +0800
From:	Wang YanQing <udknight@...il.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	hpa@...or.com, tglx@...utronix.de, mingo@...hat.com,
	x86@...nel.org, bp@...e.de, fenghua.yu@...el.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: Fix override new_cpu_data.x86 with 486

On Thu, Jun 27, 2013 at 12:54:35PM +0200, Borislav Petkov wrote:
> On Thu, Jun 27, 2013 at 12:26:40AM +0800, Wang YanQing wrote:
> > 
> > We should set X86 to 486 before use cpuid
> > to detect the cpu type, if we set X86 to 486
> > after cpuid, then we will get 486 for ever.
> 
> So not "for ever" but until cpu_detect runs.
> 
> > 
> > Yes, we will correct this in early_cpu_init,
> > but it is still a wrong behavior, right? So
> > just fix it.
> 
> Right, so this patch is correct and it fixes the small window where we
> run with family == 4 before cpu_detect but the commit message needs a
> bit massaging before it gets applied.

I think it fixes the window where we run with family > 4 before cpu_detect :)

> 
> > 
> > I also find maybe we can delete the new_cpu_data,
> > because we will over write all the information
> > in early_cpu_init, and before early_cpu_init,
> > there is no user of new_cpu_data, but this is
> > another patch in the future.
> 
> You can drop that part.

I can't catch the exactly meaning:

We can drop the new_cpu_data or 
I need to drop this part commit
message.


Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/