linux-kernel - Re: [PATCH -next] pinctrl: st: fix return value check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51CD6A21.4070201@st.com>
Date:	Fri, 28 Jun 2013 11:49:05 +0100
From:	Srinivas KANDAGATLA <srinivas.kandagatla@...com>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	linus.walleij@...aro.org, grant.likely@...aro.org,
	rob.herring@...xeda.com, devicetree-discuss@...ts.ozlabs.org,
	yongjun_wei@...ndmicro.com.cn, linux-kernel@...r.kernel.org,
	Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH -next] pinctrl: st: fix return value check

On 26/06/13 17:30, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> In case of error, the function pinctrl_register() returns
> NULL not ERR_PTR(). The IS_ERR() test in the return value
> check should be replaced with NULL test.
> The function syscon_regmap_lookup_by_phandle() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  drivers/pinctrl/pinctrl-st.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 7effedf..de8c626 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1299,9 +1299,9 @@ static int st_pctl_probe_dt(struct platform_device *pdev,
>  		return -ENOMEM;
>  
>  	info->regmap = syscon_regmap_lookup_by_phandle(np, "st,syscfg");
> -	if (!info->regmap) {
> +	if (IS_ERR(info->regmap)) {
>  		dev_err(info->dev, "No syscfg phandle specified\n");
> -		return -ENOMEM;
> +		return PTR_ERR(info->regmap);
>  	}
>  	info->data = of_match_node(st_pctl_of_match, np)->data;
>  
> @@ -1376,9 +1376,9 @@ static int st_pctl_probe(struct platform_device *pdev)
>  	pctl_desc->name		= dev_name(&pdev->dev);
>  
>  	info->pctl = pinctrl_register(pctl_desc, &pdev->dev, info);
> -	if (IS_ERR(info->pctl)) {
> +	if (!info->pctl) {
>  		dev_err(&pdev->dev, "Failed pinctrl registration\n");
> -		return PTR_ERR(info->pctl);
> +		return -EINVAL;
>  	}
>  
>  	for (i = 0; i < info->nbanks; i++)
> 
Thankyou for the patch, It looks OK.
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@...com>

Can you resend it with cc to Mark Brown <broonie@...nel.org>

Thanks,
srini



> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss@...ts.ozlabs.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/