linux-kernel - RE: [PATCH -tip] x86,trace: Add rcu_irq_enter/exit() in smp_trace_reschedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <A5ED84D3BB3A384992CBB9C77DEDA4D443E0FEEB@USINDEM103.corp.hds.com>
Date:	Fri, 28 Jun 2013 15:48:02 +0000
From:	Seiji Aguchi <seiji.aguchi@....com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
	"mingo@...e.hu" <mingo@...e.hu>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"Paul E. McKenney" <paulmck@...ibm.com>,
	Peter Zijlstra <peterz@...radead.org>
Subject: RE: [PATCH -tip] x86,trace: Add rcu_irq_enter/exit() in
 smp_trace_reschedule_interrupt()

> > +void smp_trace_reschedule_interrupt(struct pt_regs *regs)
> > +{
> 
> Sure, but we should probably add a comment here to why
> smp_trace_reschedule_interrupt() is different than
> smp_reschedule_interrupt().
> 
> 	/*
> 	 * Need to call irq_enter() before calling the trace point.
> 	 * __smp_reschedule_interrupt() calls irq_enter/exit() too (in
> 	 * scheduler_ipi(). This is OK, since those functions are allowed
> 	 * to nest.
> 	 */
> 
> -- Steve

I will add the comment.

Thanks.

Seiji