linux-kernel - Re: [PATCH] usb: Clear both buffers when clearing a control transfer TT buffer.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1306281150540.1047-100000@iolanthe.rowland.org>
Date:	Fri, 28 Jun 2013 11:56:26 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	William Gulland <wgulland@...gle.com>
cc:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>,
	Lan Tianyu <tianyu.lan@...el.com>,
	Ming Lei <ming.lei@...onical.com>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: Clear both buffers when clearing a control transfer
 TT buffer.

On Thu, 27 Jun 2013, William Gulland wrote:

>     Control transfers have both IN and OUT (or SETUP) packets, so when
>     clearing TT buffers for a control transfer it's necessary to send
>     two HUB_CLEAR_TT_BUFFER requests to the hub.

What makes you think this is necessary?  Have you found any hardware 
that requires this?

Although the USB spec doesn't say much about Clear-TT-Buffer requests,
the text in section 11.17.1 and Figure 11-47 seems to indicate that a
second Clear-TT-Buffer shouldn't be needed.  The spec says that TT
buffers are matched based on the device address, endpoint number, and
endpoint direction -- but the direction is used only for bulk
endpoints, not for control endpoints.

In particular, a control endpoint uses only one TT buffer for both the
IN and OUT directions.  So I don't think two Clear-TT-Buffers are
needed.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/