linux-kernel - Re: [PATCH 2/3] acpi: Eliminate console msg if pstore.backend excludes ERST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1199079191.10029297.1372453060353.JavaMail.root@redhat.com>
Date:	Fri, 28 Jun 2013 16:57:40 -0400 (EDT)
From:	Lenny Szubowicz <lszubowi@...hat.com>
To:	Tony Luck <tony.luck@...il.com>
Cc:	Anton Vorontsov <cbouatmailru@...il.com>,
	Matt Fleming <matt.fleming@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	n hamaguchi <n.hamaguchi@...fujitsu.com>,
	Don Zickus <dzickus@...hat.com>
Subject: Re: [PATCH 2/3] acpi: Eliminate console msg if pstore.backend
 excludes ERST



----- Original Message -----
> From: "Tony Luck" <tony.luck@...il.com>
> To: "Lenny Szubowicz" <lszubowi@...hat.com>
> Cc: "Anton Vorontsov" <cbouatmailru@...il.com>, "Matt Fleming" <matt.fleming@...el.com>, "Linux Kernel Mailing List"
> <linux-kernel@...r.kernel.org>, "n hamaguchi" <n.hamaguchi@...fujitsu.com>, "Don Zickus" <dzickus@...hat.com>
> Sent: Friday, June 28, 2013 4:44:51 PM
> Subject: Re: [PATCH 2/3] acpi: Eliminate console msg if pstore.backend excludes ERST
> 
> On Fri, Jun 28, 2013 at 1:14 PM, Lenny Szubowicz <lszubowi@...hat.com> wrote:
> 
> > -               if (pstore_register(&erst_info)) {
> > -                       pr_info(ERST_PFX "Could not register with
> > persistent store\n");
> > +               rc = pstore_register(&erst_info);
> > +               if (rc) {
> > +                       if (rc != -EPERM)
> > +                               pr_info(ERST_PFX
> > +                               "Could not register with persistent
> > store\n");
> > +                       erst_info.buf = NULL;
> > +                       erst_info.bufsize = 0;
> 
> Mismatch between part 1 and part 2 here ... we return -EINVAL if
> our name doesn't match the desired backend ... but you only suppress
> the "Could not register" message for -EPERM
> 
> Or am I confused while just looking at patch fragments?
> 
> -Tony
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

Yes, you are absolutely correct. My [PATCH 1/3] is not what I intended. Thanks!

                         -Lenny.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/