linux-kernel - Re: [PATCH 2/3] sched: fix static keys race in sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1372475008.18733.346.camel@gandalf.local.home>
Date:	Fri, 28 Jun 2013 23:03:28 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	jbaron@...mai.com
Cc:	andi@...stfloor.org, linux-kernel@...r.kernel.org,
	mingo@...nel.org, peterz@...radead.org
Subject: Re: [PATCH 2/3] sched: fix static keys race in sched_feat

On Fri, 2013-06-28 at 22:30 +0000, jbaron@...mai.com wrote:
> As pointed out by Andi Kleen, thue usage of static keys can be racy in

"thue"

> sched_feat_disable vs. sched_feat_enable(). Currently, we first check the
> value of keys->enabled, and subsequently update the branch direction. This,
> can be racy and can potentially leave the keys in an inconsistent state.
> 
> Fix the race by using static_key_slow_set_true()/false(), which does the the
> check and set using the jump_label_mutex.
> 
> Signed-off-by: Jason Baron <jbaron@...mai.com>

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/