linux-kernel - Re: [PATCH] usb: dwc3: core: continue probe even if usb3 phy is not available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130630082054.GA2634@arwen.pp.htv.fi>
Date:	Sun, 30 Jun 2013 11:20:54 +0300
From:	Felipe Balbi <balbi@...com>
To:	Michael Grzeschik <mgr@...gutronix.de>
CC:	Felipe Balbi <balbi@...com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	George Cherian <george.cherian@...com>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<gregkh@...uxfoundation.org>, <linux-omap@...r.kernel.org>,
	Kishon Vijay Abraham I <kishon@...com>,
	Alan Stern <stern@...land.harvard.edu>
Subject: Re: [PATCH] usb: dwc3: core: continue probe even if usb3 phy is not
 available

Hi,

On Fri, Jun 28, 2013 at 10:06:01PM +0200, Michael Grzeschik wrote:
> > > > > > > > right, but in DT you will define both instances and each instance will
> > > > > > > > have a seaparate snps,maximum_speed attribute :-)
> > > > > > > >
> > > > > > > > I'm now considering if we should make maximum_speed a generic attribute,
> > > > > > > > Kishon ? Alex ? Alan ?
> > > > > > > >
> > > > > > > > anyone else needs such thing ?
> > > > > > > 
> > > > > > > We have a force-full-speed attibute for chipidea on the way. This
> > > > > > > maximum_speed looks like a more generic alternative. Michael, what say
> > > > > > > you?
> > > > > > 
> > > > > > The maximum_speed attribute sounds more reasonable. I will change my
> > > > > > patch to it.
> > > > > 
> > > > > thanks, perhaps we can add a generic helper in udc-core or usb-common ?
> > > > 
> > > > As this function is not only udc specific, this should go into usb-common.
> > > > But right, we should go with a helper here. I will write one in addition
> > > > to my full-speed patch as first user of it.
> > > 
> > > alright, thanks :-)
> > 
> > Michael, if you need any help with patching in maximum_speed attribute,
> > let me know as I have some time to work on that part.
> 
> Feel free to begin with anything. I am currently short on time.
> Do you need some pointers?

not, really v1 will come on monday.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)