linux-kernel - Re: [PATCH 1/3] mm/slub: Fix slub calculate active slabs uncorrectly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0000013f9b8d6897-d2399224-d203-4dc5-a700-90dea9be7536-000000@email.amazonses.com>
Date:	Mon, 1 Jul 2013 18:45:03 +0000
From:	Christoph Lameter <cl@...ux.com>
To:	Wanpeng Li <liwanp@...ux.vnet.ibm.com>
cc:	Pekka Enberg <penberg@...nel.org>, Matt Mackall <mpm@...enic.com>,
	Glauber Costa <glommer@...allels.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Joonsoo Kim <js1304@...il.com>,
	David Rientjes <rientjes@...gle.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] mm/slub: Fix slub calculate active slabs
 uncorrectly

On Thu, 27 Jun 2013, Wanpeng Li wrote:

> Enough slabs are queued in partial list to avoid pounding the page allocator
> excessively. Entire free slabs are not discarded immediately if there are not
> enough slabs in partial list(n->partial < s->min_partial). The number of total
> slabs is composed by the number of active slabs and the number of entire free
> slabs, however, the current logic of slub implementation ignore this which lead
> to the number of active slabs and the number of total slabs in slabtop message
> is always equal. This patch fix it by substract the number of entire free slabs
> in partial list when caculate active slabs.

What do you mean by "active" slabs? If this excludes the small number of
empty slabs that could be present then indeed you will not have that
number. But why do you need that?

The number of total slabs is the number of partial slabs, plus the number
of full slabs plus the number of percpu slabs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/