linux-kernel - Re: [PATCH 0/4] usb: ohci-ep93xx: do a bit of house cleaning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1307011714450.1547-100000@iolanthe.rowland.org>
Date:	Mon, 1 Jul 2013 17:18:50 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	<kernel@...tstofly.org>, <gregkh@...uxfoundation.org>,
	<hsweeten@...ionengravers.com>
Subject: Re: [PATCH 0/4] usb: ohci-ep93xx: do a bit of house cleaning

On Fri, 28 Jun 2013, H Hartley Sweeten wrote:

> Tidy up this driver a bit.
> 
> H Hartley Sweeten (4):
>   usb: ohci-ep93xx: use devm_ioremap_resource()
>   usb: ohci-ep93xx: use platform_get_irq()
>   usb: ohci-ep93xx: use devm_clk_get()
>   usb: ohci-ep93xx: tidy up ohci_hcd_ep93xx_drv_probe()

Patches 1 - 3 look fine; you can add my Acked-by: to them.

For patch 4, we really should have a little more tidying up.  The 
ohci_hcd_ep93xx_drv_probe() routine should be merged with 
usb_hcd_ep93xx_probe(); there's no reason for them to be separate.  
Likewise for ohci_hcd_ep93xx_drv_remove() and usb_hcd_ep93xx_remove().

Also, if you feel up to it, I think it would make sense to eliminate 
the ep93xx_start_hc() and ep93xx_stop_hc() routines and simply call 
clk_enable() and clk_disable() directly.  The extra level of 
redirection does not add any clarity.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/