linux-kernel - Re: [PATCH] m68k/mac: Allocate IOP message pool and queues dynamically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Jul 2013 14:59:32 -0700
From:	Brad Boyer <flar@...thia.pants.nu>
To:	Finn Thain <fthain@...egraphics.com.au>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68k/mac: Allocate IOP message pool and queues
 dynamically

On Mon, Jul 01, 2013 at 05:46:48PM +1000, Finn Thain wrote:
> 
> On Sun, 30 Jun 2013, Geert Uytterhoeven wrote:
> 
> > -
> > -/*
> > - * Register the interrupt handler for the IOPs.
> > - * TODO: might be wrong for non-OSS machines. Anyone?
> > - */
> > -
> > -void __init iop_register_interrupts(void)
> > -{
> > -	if (iop_ism_present) {
> > +		/*
> > +		 * Register the interrupt handler for the IOPs.
> > +		 * TODO: might be wrong for non-OSS machines. Anyone?
> 
> My testing with a non-OSS machine (Quadra 950) indicates that the TODO is 
> obsolete. And the comment "register the interrupt handler for the IOPs" is 
> a bit silly. It merely re-phrases the code. Otherwise, this patch looks 
> good to me. Thanks.

The code was all originally written and tested only on the IIfx. That's
all JMT had, and at the time it was all I had as well. I have since
acquired a Quadra 950. Lots of these comments are just out of date. I
know it got tested on either a Quadra 900 or Quadra 950 after that
comment was put in the source.

	Brad Boyer
	flar@...andria.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/