linux-kernel - Re: [PATCH v2 4/4] usb: ohci-ep93xx: tidy up driver (*probe) and (*remove)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 2 Jul 2013 11:08:08 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	<kernel@...tstofly.org>, <gregkh@...uxfoundation.org>,
	<hsweeten@...ionengravers.com>
Subject: Re: [PATCH v2 4/4] usb: ohci-ep93xx: tidy up driver (*probe) and
 (*remove)

On Mon, 1 Jul 2013, H Hartley Sweeten wrote:

> Merge the usb_hcd_ep93xx_probe() into ohci_hcd_ep93xx_drv_probe() and
> the usb_hcd_ep93xx_remove() into ohci_hcd_ep93xx_drv_remove(). As Alan
> Stern pointed out, there is no reason for them to be separate.
> 
> Also, as Alan Stern suggested, eliminate the ep93xx_start_hc() and
> ep93xx_stop_hc() routines and simply call clk_enable() and clk_disable()
> directly. The extra level of redirection does not add any clarity.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Alan Stern <stern@...land.harvard.edu>
> Cc: Lennert Buytenhek <kernel@...tstofly.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Acked-by: Alan Stern <stern@...land.harvard.edu>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/