linux-kernel - Re: [PATCH 04/13] android/sw_sync: use get_unused_fd_flags(0) instead of get_unused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACSP8SjZcpcpEtQHzcGYhf-MP7QGo0XpN7-uN7rmD=vNtopG=w@mail.gmail.com>
Date:	Tue, 2 Jul 2013 15:22:58 -0700
From:	Erik Gilling <konkers@...roid.com>
To:	Yann Droneaud <ydroneaud@...eya.com>,
	Colin Cross <ccross@...gle.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH 04/13] android/sw_sync: use get_unused_fd_flags(0) instead
 of get_unused_fd()

On Tue, Jul 2, 2013 at 9:39 AM, Yann Droneaud <ydroneaud@...eya.com> wrote:
>  static long sw_sync_ioctl_create_fence(struct sw_sync_timeline *obj,
>                                        unsigned long arg)
>  {
> -       int fd = get_unused_fd();
> +       int fd = get_unused_fd_flags(0);

I think we should use O_CLOEXEC here.  Colin and I can't think of any
case where one would want keep fences across exec.

Cheers,
   Erik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/