linux-kernel - Re: linux-next: Tree for Jul 4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 4 Jul 2013 11:12:43 +0200
From:	Sedat Dilek <sedat.dilek@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Li Zefan <lizefan@...wei.com>
Subject: Re: linux-next: Tree for Jul 4

On Thu, Jul 4, 2013 at 10:45 AM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
> On Thu, 4 Jul 2013 10:21:09 +0200 Sedat Dilek <sedat.dilek@...il.com> wrote:
>
>> I have compared both mm/memcontrol.c files from
>> next-20130703/next-20130704 - they are identical.
>>
>> These hunks...
>>
>> [ From Li Zefan ]
>> @@ -6332,8 +6341,7 @@ static void mem_cgroup_css_free(struct cgroup *cont)
>>  {
>>         struct mem_cgroup *memcg = mem_cgroup_from_cont(cont);
>>
>> -       mem_cgroup_sockets_destroy(memcg);
>> -
>> +       memcg_destroy_kmem(memcg);
>>         __mem_cgroup_free(memcg);
>>  }
>>
>> [ From mmots ]
>> @@ -6399,8 +6408,7 @@ static void mem_cgroup_css_free(struct c
>>  {
>>         struct mem_cgroup *memcg = mem_cgroup_from_cont(cont);
>>
>> -       mem_cgroup_sockets_destroy(memcg);
>> -
>> +       memcg_destroy_kmem(memcg);
>>         mem_cgroup_put(memcg);
>>  }
>>
>> ...seems to differ.
>>
>> In both mentioned -next releases there exist no mem_cgroup_put() in
>> mm/memcontrol.c.
>> So the hunk in mmots seems to be wrong in my eyes.
>
> Seems right - thanks for catching that.
>
> --- a/mm/memcontrol.c~memcg-use-css_get-put-when-charging-uncharging-kmem-fix-fix-fix
> +++ a/mm/memcontrol.c
> @@ -6409,7 +6409,7 @@ static void mem_cgroup_css_free(struct c
>         struct mem_cgroup *memcg = mem_cgroup_from_cont(cont);
>
>         memcg_destroy_kmem(memcg);
> -       mem_cgroup_put(memcg);
> +       __mem_cgroup_free(memcg);
>  }
>
>  #ifdef CONFIG_MMU
> _
>

Hmm, if...

     memcg-use-css_get-put-when-charging-uncharging-kmem-fix-fix.patch

...does not apply here, a follow-up makes not really sense to me...

     memcg-use-css_get-put-when-charging-uncharging-kmem-fix-fix-fix.patch

Maybe, I am wrong seeing it from -next side than -mm.
( Might be you want to keep the chronology. )
Anyway, dunno, will fold that into -fix-fix.

- Sedat
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/