linux-kernel - Re: [PATCH] irqchip: vt8500: Staticize local symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 05 Jul 2013 06:32:41 +1200
From:	Tony Prisk <linux@...sktech.co.nz>
To:	Axel Lin <axel.lin@...ics.com>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	Olof Johansson <olof@...om.net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip: vt8500: Staticize local symbols

On 04/07/13 18:11, Axel Lin wrote:
> This driver is converted to use IRQCHIP_DECLARE and irqchip_init.
> vt8500_handle_irq() and vt8500_irq_init() are only referenced in this file now,
> make them static.
>
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>   drivers/irqchip/irq-vt8500.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-vt8500.c b/drivers/irqchip/irq-vt8500.c
> index d970595..1846e7d 100644
> --- a/drivers/irqchip/irq-vt8500.c
> +++ b/drivers/irqchip/irq-vt8500.c
> @@ -178,7 +178,8 @@ static struct irq_domain_ops vt8500_irq_domain_ops = {
>   	.xlate = irq_domain_xlate_onecell,
>   };
>   
> -asmlinkage void __exception_irq_entry vt8500_handle_irq(struct pt_regs *regs)
> +static asmlinkage
> +void __exception_irq_entry vt8500_handle_irq(struct pt_regs *regs)
>   {
>   	u32 stat, i;
>   	int irqnr, virq;
> @@ -203,7 +204,8 @@ asmlinkage void __exception_irq_entry vt8500_handle_irq(struct pt_regs *regs)
>   	}
>   }
>   
> -int __init vt8500_irq_init(struct device_node *node, struct device_node *parent)
> +static int __init vt8500_irq_init(struct device_node *node,
> +				  struct device_node *parent)
I prefer that the function variables are lined up, rather than aligning 
with the (. Can you move the 'struct device_node *parent' across one 
more space?

Otherwise:

Acked-by: Tony Prisk <linux@...sktech.co.nz>
>   {
>   	int irq, i;
>   	struct device_node *np = node;

Regards
Tony P
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/