linux-kernel - Re: [PATCH] include/asm-generic/io.h: add dummy fuctions to support 'COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201307051313.43491.arnd@arndb.de>
Date:	Fri, 5 Jul 2013 13:13:43 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Chen Gang F T <chen.gang.flying.transformer@...il.com>
Cc:	Chen Gang <gang.chen@...anux.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Greg KH <gregkh@...uxfoundation.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Richard Weinberger <richard@....at>,
	Jeff Dike <jdike@...toit.com>,
	David Sharp <dhsharp@...gle.com>,
	Ingo Molnar <mingo@...nel.org>,
	"uml-devel" <user-mode-linux-devel@...ts.sourceforge.net>,
	"uml-user" <user-mode-linux-user@...ts.sourceforge.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Linux-Arch" <linux-arch@...r.kernel.org>,
	Mark Brown <broonie@...nel.org>,
	David Miller <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jiri Kosina <trivial@...nel.org>, Jiri Slaby <jslaby@...e.cz>
Subject: Re: [PATCH] include/asm-generic/io.h: add dummy fuctions to support 'COMPILE_TEST' in 'asm-generic'.

On Friday 05 July 2013, Chen Gang F T wrote:
> Hello All:
> 
> It seems 'asm-generic' dislikes 'mad users' (e.g allmodconfig,
> randconfig, and me).
> 
> I guess the main reason is: 'asm-generic' thinks what mad users talk
> about is useless in real world, so it is just noisy.
> 
> I can understand, at least what I talk about is not for urgent things.
> (maybe 'asm-generic' also thinks it not important either, every members
> have their own opinions).
> 
> Next, I still use allmodconfig/randconfig for some architectures which I
> am interested in (and also for learning compilers), but I will skip all
> things which are related with 'asm-generic', since it dislikes me (a mad
> user).

As the asm-generic maintainer I think I have to clarify a few things:

* Build-time fixes for warnings and randconfig errors are good,
  and you have sent a number of good bug fixes all over the kernel,
  I definitely welcome getting more of those. In many cases the
  fix is trivial and obvious, in other cases you need to know
  much more of the background to understand what the underlying
  problem is and why you should not just fix the symptom.

* You have made an (understandable) mistake with this particular
  patch. It would have been nice if you had not made it, but I
  can see that you are still learning about these things. There
  is a fine line between what makes sense to be enabled as a
  'compile test' and what should better be left disabled by
  Kconfig.

* When experienced developers tell you that you are mistaken, you
  need to make an effort to understand what the mistake was so you
  can learn from it and not make the same mistake again. If you
  make the same mistakes again, maintainers will get annoyed and
  ignore you (or worse), which is not a good situation to be
  in when you want to get your patches merged.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/