linux-kernel - Re: [PATCH V4 14/21] perf tools: change "machine" functions to set thread pid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51D83EA7.4060600@gmail.com>
Date:	Sat, 06 Jul 2013 09:58:31 -0600
From:	David Ahern <dsahern@...il.com>
To:	Adrian Hunter <adrian.hunter@...el.com>
CC:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...hat.com>, Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH V4 14/21] perf tools: change "machine" functions to set
 thread pid

On 7/4/13 7:20 AM, Adrian Hunter wrote:
> Typically tracking events such as mmap events, comm events,
> fork events and exit events, are processed by "machine"
> functions.  Change these functions to put pid in the new
> pid_ member of struct thread.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
> ---
>   tools/perf/util/machine.c | 21 +++++++++++++++++----
>   tools/perf/util/machine.h |  2 ++
>   2 files changed, 19 insertions(+), 4 deletions(-)
>

---8<---

> diff --git a/tools/perf/util/machine.h b/tools/perf/util/machine.h
> index e49ba01..d986ecf 100644
> --- a/tools/perf/util/machine.h
> +++ b/tools/perf/util/machine.h
> @@ -100,6 +100,8 @@ static inline bool machine__is_host(struct machine *machine)
>   }
>
>   struct thread *machine__findnew_thread(struct machine *machine, pid_t tid);
> +struct thread *machine__findnew_thread_ex(struct machine *machine, pid_t pid,
> +					  pid_t tid);
>
>   size_t machine__fprintf(struct machine *machine, FILE *fp);
>
>


Why do you want to add a new API for this? Why not just fix 
findnew_thread and find_thread to take the pid argument? We don't need 2 
apis that do the same thing.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/