linux-kernel - Re: [RFC PATCH 1/5] driver core: Introduce device_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130706192221.GB15066@roeck-us.net>
Date:	Sat, 6 Jul 2013 12:22:21 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Jean Delvare <khali@...ux-fr.org>, lm-sensors@...sensors.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 1/5] driver core: Introduce device_create_groups

On Sat, Jul 06, 2013 at 10:47:58AM -0700, Greg Kroah-Hartman wrote:
> On Sat, Jul 06, 2013 at 10:24:51AM -0700, Guenter Roeck wrote:
> > device_create_groups lets callers create devices as well as associated
> > sysfs attributes with a single call. This avoids race conditions seen
> > if sysfs attributes on new devices are created later.
> > 
> > Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> > ---
> >  drivers/base/core.c    |   60 +++++++++++++++++++++++++++++++++++++++++++++---
> >  include/linux/device.h |    4 ++++
> >  2 files changed, 61 insertions(+), 3 deletions(-)
> 
> Ok, in reading the code, it makes more sense to me now.  That looks
> good, but the name is a bit rough.  How many device_create() calls do we
> have in the kernel today?
> 
> $ git grep -w device_create | wc -l
> 127
> 
> That's really not that many, I wonder how many of those should be using
> something like this as well?  A quick look showed that the sound core
> should be using this, but maybe not all that many others...
> 
Pretty much all hwmon devices. Given that, another option would be to not use
device_create in the hwmon core code, but more or less re-write it there.
I don't think that would be such a good idea, but it is my fallback option.

> My objection to the name is at first glance, it sounds like you are
> creating "groups", not a device + groups.
> "device_create_with_groups()"?
> 
No problem. You pick the name ...

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/