linux-kernel - Re: [PATCH 1/4] usb: limit OMAP related USB options to OMAP2PLUS platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130708075605.GA29100@arwen.pp.htv.fi>
Date:	Mon, 8 Jul 2013 10:56:22 +0300
From:	Felipe Balbi <balbi@...com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>, <linux-kernel@...r.kernel.org>,
	Felipe Balbi <balbi@...com>,
	Kishon Vijay Abraham I <kishon@...com>
Subject: Re: [PATCH 1/4] usb: limit OMAP related USB options to OMAP2PLUS
 platforms

On Thu, Jul 04, 2013 at 01:39:10AM -0400, Paul Gortmaker wrote:
> commit 57f6ce072e35770a63be0c5d5e82f90d8da7d665 ("usb: phy:
> add a new driver for usb3 phy") added the new Kconfig option
> OMAP_USB3, but it had no dependencies whatsoever, and hence
> became available across all arch/platforms.
> 
> Which presumably caused this to show up in x86 randconfig:
> 
>     warning: (USB_MUSB_HDRC && OMAP_USB3) selects \
>         OMAP_CONTROL_USB which has unmet direct \
>         dependencies (USB_SUPPORT && ARCH_OMAP2PLUS)
> 
> Then commit 6992819feb39cb9adac72170555d957d07f869f2 ("usb: phy:
> fix Kconfig warning") was added.  However, this just deleted the
> ARCH_OMAP2PLUS dependency from OMAP_CONTROL_USB, further
> compounding the problem by opening up OMAP_CONTROL_USB to
> all arch/platforms as well.
> 
> Earlier it was suggested[1] that we revert the change of 6992819feb
> to restore the dependency, and add a same ARCH_OMAP2PLUS dependency
> to the new OMAP_USB3 entry.  However that was discouraged on the
> grounds of people wanting the extra sanity compile testing on x86,
> even though the driver could probably never be used there.
> 
> Now we have CONFIG_COMPILE_TEST, so developers who value the ability
> to compile drivers on an architecture that it never can be used for
> can have that, and people who want dependencies to shield them from
> seeing options that aren't relevant to their platform get what they
> want too.
> 
> Here we restore the dependency but couple it with COMPILE_TEST, in
> order to achieve both of the above goals.
> 
> [1] https://patchwork.kernel.org/patch/2194511/
> 
> Cc: Felipe Balbi <balbi@...com>
> Cc: Kishon Vijay Abraham I <kishon@...com>
> Cc: Moiz Sonasath <m-sonasath@...com>
> Cc: Jiri Slaby <jslaby@...e.cz>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Acked-by: Felipe Balbi <balbi@...com>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)