linux-kernel - Re: [PATCH] USB: EHCI: Fix resume signalling on remote wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1307091124050.1077-100000@iolanthe.rowland.org>
Date:	Tue, 9 Jul 2013 11:24:39 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Roger Quadros <rogerq@...com>
cc:	gregkh@...uxfoundation.org, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] USB: EHCI: Fix resume signalling on remote wakeup

On Tue, 9 Jul 2013, Roger Quadros wrote:

> Set the ehci->resuming flag for the port we receive a remote
> wakeup on so that resume signalling can be completed.
> 
> Without this, the root hub timer will not fire again to check
> if the resume was completed and there will be a never-ending wait on
> on the port.
> 
> This effect is only observed if the HUB IRQ IN does not come after we
> have initiated the port resume.
> 
> Signed-off-by: Roger Quadros <rogerq@...com>
> ---
>  drivers/usb/host/ehci-hub.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
> index 9ab4a4d..ca6289b 100644
> --- a/drivers/usb/host/ehci-hub.c
> +++ b/drivers/usb/host/ehci-hub.c
> @@ -858,6 +858,7 @@ static int ehci_hub_control (
>  				ehci->reset_done[wIndex] = jiffies
>  						+ msecs_to_jiffies(20);
>  				usb_hcd_start_port_resume(&hcd->self, wIndex);
> +				set_bit(wIndex, &ehci->resuming_ports);
>  				/* check the port again */
>  				mod_timer(&ehci_to_hcd(ehci)->rh_timer,
>  						ehci->reset_done[wIndex]);

Acked-by: Alan Stern <stern@...land.harvard.edu>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/