linux-kernel - [PATCH linux-next] edma: select arch common code to fix link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 9 Jul 2013 18:49:20 +0200
From:	Vincent Stehlé <vincent.stehle@...escale.com>
To:	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <linux-next@...r.kernel.org>
CC:	Vincent Stehlé <vincent.stehle@...escale.com>,
	Matt Porter <mporter@...com>, Sekhar Nori <nsekhar@...com>,
	Vinod Koul <vinod.koul@...el.com>, Dan Williams <djbw@...com>,
	Russell King <linux@....linux.org.uk>
Subject: [PATCH linux-next] edma: select arch common code to fix link

EDMA code has been moved to a common folder with a new CONFIG_TI_PRIV_EDMA
switch. Select it when the edma driver is enabled.

This fixes the following link error:

  drivers/built-in.o: In function `edma_remove':
  of_iommu.c:(.text+0x4ef20): undefined reference to `edma_free_slot'
  drivers/built-in.o: In function `edma_control':
  of_iommu.c:(.text+0x4ef70): undefined reference to `edma_stop'
  drivers/built-in.o: In function `edma_execute':
  of_iommu.c:(.text+0x4f11c): undefined reference to `edma_write_slot'
  of_iommu.c:(.text+0x4f150): undefined reference to `edma_link'
  of_iommu.c:(.text+0x4f168): undefined reference to `edma_start'
  drivers/built-in.o: In function `edma_free_chan_resources':
  of_iommu.c:(.text+0x4f220): undefined reference to `edma_stop'
  of_iommu.c:(.text+0x4f304): undefined reference to `edma_free_slot'
  of_iommu.c:(.text+0x4f328): undefined reference to `edma_free_channel'
  drivers/built-in.o: In function `edma_alloc_chan_resources':
  of_iommu.c:(.text+0x4f37c): undefined reference to `edma_alloc_channel'
  of_iommu.c:(.text+0x4f3d8): undefined reference to `edma_free_channel'
  drivers/built-in.o: In function `edma_prep_slave_sg':
  of_iommu.c:(.text+0x4f67c): undefined reference to `edma_alloc_slot'
  drivers/built-in.o: In function `edma_probe':
  of_iommu.c:(.text+0x4f794): undefined reference to `edma_alloc_slot'
  of_iommu.c:(.text+0x4f8b8): undefined reference to `edma_free_slot'
  drivers/built-in.o: In function `edma_callback':
  of_iommu.c:(.text+0x4fae4): undefined reference to `edma_stop'
  make: *** [vmlinux] Error 1

Signed-off-by: Vincent Stehlé <vincent.stehle@...escale.com>
Cc: Matt Porter <mporter@...com>
Cc: Sekhar Nori <nsekhar@...com>
Cc: Vinod Koul <vinod.koul@...el.com>
Cc: Dan Williams <djbw@...com>
Cc: Russell King <linux@....linux.org.uk>
---


Hi,

Build of linux next-20130709 is broken for ARM multi_v7_defconfig. This patch
fixes it.

(Note: the error messages mentioning of_iommu.c are misleading.)

Best regards,

V.


 drivers/dma/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 6825957..8b3fca9 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -198,6 +198,7 @@ config TI_EDMA
 	depends on ARCH_DAVINCI || ARCH_OMAP
 	select DMA_ENGINE
 	select DMA_VIRTUAL_CHANNELS
+	select TI_PRIV_EDMA
 	default n
 	help
 	  Enable support for the TI EDMA controller. This DMA
-- 
1.7.10.4



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/