linux-kernel - Re: [PATCH] USB: host: Use usb_hcd_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51DD1663.60006@ti.com>
Date:	Wed, 10 Jul 2013 11:08:03 +0300
From:	Roger Quadros <rogerq@...com>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	<gregkh@...uxfoundation.org>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] USB: host: Use usb_hcd_platform_shutdown() wherever possible

On 07/09/2013 05:16 PM, Alan Stern wrote:
> On Tue, 9 Jul 2013, Roger Quadros wrote:
> 
>> Most HCD drivers are doing the same thing in their ".shutdown" callback
>> so it makes sense to use the generic usb_hcd_platform_shutdown()
>> handler there.
>>
>> Signed-off-by: Roger Quadros <rogerq@...com>
>> ---
>>  drivers/usb/host/ehci-grlib.c     |   11 +----------
>>  drivers/usb/host/ehci-mxc.c       |   10 +---------
>>  drivers/usb/host/ehci-omap.c      |   10 +---------
>>  drivers/usb/host/ehci-ppc-of.c    |   11 +----------
>>  drivers/usb/host/ehci-s5p.c       |   10 +---------
>>  drivers/usb/host/ehci-tegra.c     |   10 +---------
>>  drivers/usb/host/ehci-xilinx-of.c |   17 +----------------
>>  drivers/usb/host/ohci-omap3.c     |   10 +---------
>>  8 files changed, 8 insertions(+), 81 deletions(-)
> 
> This all looks fine.  But unless my kernel tree is out of date, you 
> missed ohci-ppc-of.c.

You are right. I missed it and will send a revision.

I've also noticed some drivers doing non-standard stuff.
e.g.
- ehci-ps3.c and ohci-pst set .shutdown as well as .remove to to ps3_ehci_remove
- ehci-tilegx.c and ohci-tilegx call .remove in the .shutdown path
- ehci-mv.c checks for (!hcd->rh_registered) in the shudown & remove patch.
Is this necessary?

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/