linux-kernel - [PATCH] kexec: return error of machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1373421296-6112-1-git-send-email-horms@verge.net.au>
Date:	Wed, 10 Jul 2013 10:54:56 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Stephen Warren <swarren@...dotorg.org>,
	Stephen Warren <swarren@...dia.com>, kexec@...ts.infradead.org,
	Eric Biederman <ebiederm@...ssion.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] kexec: return error of machine_kexec() fails

From: Stephen Warren <swarren@...dia.com>

Prior to commit 3ab8352 "kexec jump", if machine_kexec() returned,
sys_reboot() would return -EINVAL. This patch restores this behaviour
for the non-KEXEC_JUMP case, where machine_kexec() is not expected to
return.

This situation can occur on ARM, where kexec requires disabling all but
one CPU using CPU hotplug. However, if hotplug isn't supported by the
particular HW the kernel is running on, then kexec cannot succeed.

Signed-off-by: Stephen Warren <swarren@...dia.com>
Acked-by: Will Deacon <will.deacon@....com>
Acked-by: Zhang Yanfei <zhangyanfei@...fujitsu.com>
Acked-by: Simon Horman <horms@...ge.net.au>
---
 kernel/kexec.c | 2 ++
 1 file changed, 2 insertions(+)

Andrew, could you consider picking up this patch?

diff --git a/kernel/kexec.c b/kernel/kexec.c
index 59f7b55..bde1190 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -1702,6 +1702,8 @@ int kernel_kexec(void)
 		pm_restore_console();
 		unlock_system_sleep();
 	}
+#else
+	error = -EINVAL;
 #endif
 
  Unlock:
-- 
1.8.2.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/