linux-kernel - Re: [PATCH v2 1/2] ARM: dt: t30 cardhu: add dt entry for nct1008

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130710171319.GB15665@dhcp-172-17-186-34.nvidia.com>
Date:	Wed, 10 Jul 2013 10:13:20 -0700
From:	Thierry Reding <thierry.reding@...il.com>
To:	Wei Ni <wni@...dia.com>
Cc:	khali@...ux-fr.org, swarren@...dotorg.org, linux@...ck-us.net,
	lm-sensors@...sensors.org, linux-kernel@...r.kernel.org,
	linux-tegra@...r.kernel.org
Subject: Re: [PATCH v2 1/2] ARM: dt: t30 cardhu: add dt entry for nct1008

On Wed, Jul 10, 2013 at 07:29:57PM +0800, Wei Ni wrote:
> Enable thermal sensor nct1008 for t30 cardhu.

Nit: "Tegra30 Cardhu"

> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
[...]
>  				};
>  			};
>  		};
> +
> +		nct1008: nct1008 {

I don't think it's very likely that this chip will need to be referenced
by a phandle, in which case the "nct1008:" label can be dropped. Even if
it was used at some point in the future, it's better to add it at that
time.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)