linux-kernel - Re: [PATCH V2] relay: fix timer madness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130709205755.aca39829.akpm@linux-foundation.org>
Date:	Tue, 9 Jul 2013 20:57:55 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Li Zefan <lizefan@...wei.com>
Cc:	"zhangwei(Jovi)" <jovi.zhangwei@...wei.com>,
	Ingo Molnar <mingo@...hat.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Jens Axboe <axboe@...nel.dk>,
	Al Viro <viro@...iv.linux.org.uk>,
	Eric Dumazet <edumazet@...gle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] relay: fix timer madness

On Wed, 10 Jul 2013 11:37:26 +0800 Li Zefan <lizefan@...wei.com> wrote:

> On 2013/7/10 10:18, zhangwei(Jovi) wrote:
> > When I'm using ktap script to tracing all event tracepoints by relay
> > transport, without this patch, the system will hang in few seconds.
> > 
> > I found the original patch discussion in 2007.
> > http://marc.info/?l=linux-kernel&m=118544794717162&w=2
> > (In that mail thread, the patch didn't fix that problem, but it fix
> > the problem I encountered now)
> > 
> > Changed from v1:
> > mod timer interval changed from jiffies+1 to HZ/10, as Ingo suggested.
> > 
> > Original patch changelog from Ingo in 2007:
> > 
> > Remove timer calls (!!!) from deep within the tracing infrastructure.
> > This was totally bogus code that can cause lockups and worse.
> > Poll the buffer every 2 jiffies for now.
> > 
> > Signed-off-by: Ingo Molnar <mingo@...e.hu>
> > Signed-off-by: "zhangwei(Jovi)" <jovi.zhangwei@...wei.com>
> > Cc: Steven Rostedt <rostedt@...dmis.org>
> > Cc: Jens Axboe <axboe@...nel.dk>
> > Cc: Al Viro <viro@...iv.linux.org.uk>
> > Cc: Eric Dumazet <edumazet@...gle.com>
> > Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> 
> I don't think this patch should have Andrew's signed-off-by?

I guess not, unless it was taken from -mm, which would be odd, as I
have the old version.

v1 has been in my tree for a few months - Ingo requested some updates
but nothing happened and I have not checked whether v2 addresses his
requests.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/