linux-kernel - Re: [PATCH V3 1/3] dts: change Marvell prefix to 'marvell'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130710215041.GR11908@titan.lakedaemon.net>
Date:	Wed, 10 Jul 2013 17:50:41 -0400
From:	Jason Cooper <jason@...edaemon.net>
To:	Haojian Zhuang <haojian.zhuang@...il.com>
Cc:	Neil Zhang <zhangwm@...vell.com>,
	Grant Likely <grant.likely@...aro.org>,
	Bergmann Arnd <arnd@...db.de>,
	devicetree-discuss@...ts.ozlabs.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V3 1/3] dts: change Marvell prefix to 'marvell'

On Wed, Jul 10, 2013 at 10:08:50PM +0800, Haojian Zhuang wrote:
> On Wed, Jul 10, 2013 at 8:24 PM, Jason Cooper <jason@...edaemon.net> wrote:
> > On Wed, Jul 10, 2013 at 04:19:46PM +0800, Haojian Zhuang wrote:
> >> On Tue, Jul 9, 2013 at 8:49 PM, Jason Cooper <jason@...edaemon.net> wrote:
> >> > Neil,
> >> >
> >> > On Tue, Jul 09, 2013 at 02:42:44PM +0800, Neil Zhang wrote:
> >> >> The documented vendor prefix for Marvell is 'marvell', not 'mrvl', so
> >> >> let's change it.
> >> >>
> >> >> Signed-off-by: Neil Zhang <zhangwm@...vell.com>
> >> >> ---
> >> >>  .../devicetree/bindings/arm/mrvl/intc.txt          |   16 +++---
> >> >>  .../devicetree/bindings/arm/mrvl/mrvl.txt          |    6 +-
> >> >>  .../devicetree/bindings/arm/mrvl/timer.txt         |    4 +-
> >> >>  Documentation/devicetree/bindings/i2c/i2c-pxa.txt  |   14 +++---
> >> >>  .../devicetree/bindings/mmc/sdhci-pxa.txt          |    8 ++--
> >> >>  .../devicetree/bindings/rtc/sa1100-rtc.txt         |    4 +-
> >> >>  .../devicetree/bindings/serial/mrvl-serial.txt     |    2 +-
> >> >>  arch/arm/boot/dts/mmp2-brownstone.dts              |    2 +-
> >> >>  arch/arm/boot/dts/mmp2.dtsi                        |   56 ++++++++++----------
> >> >>  arch/arm/boot/dts/pxa168-aspenite.dts              |    2 +-
> >> >>  arch/arm/boot/dts/pxa168.dtsi                      |   24 ++++----
> >> >>  arch/arm/boot/dts/pxa2xx.dtsi                      |   16 +++---
> >> >>  arch/arm/boot/dts/pxa3xx.dtsi                      |    2 +-
> >> >>  arch/arm/boot/dts/pxa910-dkb.dts                   |    2 +-
> >> >>  arch/arm/boot/dts/pxa910.dtsi                      |   27 +++++-----
> >> >>  arch/arm/mach-mmp/irq.c                            |   16 +++---
> >> >>  arch/arm/mach-mmp/mmp-dt.c                         |   28 +++++-----
> >> >>  arch/arm/mach-mmp/mmp2-dt.c                        |   16 +++---
> >> >>  arch/arm/mach-mmp/time.c                           |    2 +-
> >> >>  arch/arm/mach-pxa/pxa-dt.c                         |   14 +++---
> >> >>  drivers/i2c/busses/i2c-pxa.c                       |   10 ++--
> >> >>  drivers/mmc/host/sdhci-pxav2.c                     |    4 +-
> >> >>  drivers/mmc/host/sdhci-pxav3.c                     |    4 +-
> >> >>  drivers/rtc/rtc-sa1100.c                           |    4 +-
> >> >>  drivers/tty/serial/pxa.c                           |    4 +-
> >> >>  25 files changed, 144 insertions(+), 143 deletions(-)
> >> >
> >> > I agree with the need to change, however, this has been in the binding
> >> > documentation since v3.5.  I wish we had caught this when we decided
> >> > against using stock ticker symbols (not all stock markets use
> >> > alphabetical abbreviated names, not all companies are listed on any
> >> > stock exchange).
> >> >
> >> > To do this properly, the drivers are going to have to be compatible with
> >> > the old and the new names, and the binding docs updated to reflect the
> >> > legacy name and the preferred name.
> >> >
> >>
> >> It's better to only use the new names.
> >
> > In the dts{i}, yes.  But we don't want to break systems in the field
> > with "mrvl,..." compatible strings.  Therefore, at least the drivers
> > need an extra compatible string to support "mrvl,...".
> >
> > If it had just been since v3.9, it'd be different/simpler.  However,
> > several vendors have opted to use kernels newer than v3.5, which makes
> > this scenario a real possibility.
> >
> > thx,
> >
> > Jason.
> 
> Is there any vendor using DT for this Marvell chip? I think the answer is no.

Well, Daniel Drake spoke up for OLPC.  Does that count?

thx,

Jason.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/