linux-kernel - Re: [tpmdd-devel] [PATCH 3/4] tpm: Convert tpm_tis driver to use dev_pm_ops from legacy pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201307110051.04726.PeterHuewe@gmx.de>
Date:	Thu, 11 Jul 2013 00:51:04 +0200
From:	Peter Hüwe <PeterHuewe@....de>
To:	tpmdd-devel@...ts.sourceforge.net
Cc:	Shuah Khan <shuah.kh@...sung.com>, rafael.j.wysocki@...el.com,
	bhelgaas@...gle.com, a.zummo@...ertech.it, key@...ux.vnet.ibm.com,
	mail@...jiv.net, tpmdd@...horst.net, tpmdd@...rix.com,
	matthew.garrett@...ula.com, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
	shuahkhan@...il.com
Subject: Re: [tpmdd-devel] [PATCH 3/4] tpm: Convert tpm_tis driver to use dev_pm_ops from legacy pm_ops

Hi,

thanks for your patch
>  static struct pnp_device_id tpm_pnp_tbl[] = {
>  	{"PNP0C31", 0},		/* TPM */
>  	{"ATM1200", 0},		/* Atmel */
> @@ -835,9 +834,12 @@ static struct pnp_driver tis_pnp_driver = {
>  	.name = "tpm_tis",
>  	.id_table = tpm_pnp_tbl,
>  	.probe = tpm_tis_pnp_init,
> -	.suspend = tpm_tis_pnp_suspend,
> -	.resume = tpm_tis_pnp_resume,
>  	.remove = tpm_tis_pnp_remove,
> +#ifdef CONFIG_PM_SLEEP
> +	.driver	= {
> +		.pm = &tpm_tis_pm,
> +	},
> +#endif
>  };


I don't think the #if CONFIG_PM_SLEEP is required here.

Thanks,
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/