linux-kernel - Re: [PATCH] usb: gadget: fotg210-udc: Remove bogus __init/_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUxfaXV=npJCn90CGSFpdcPkmWGxbX+ej9NFKSWuKgGRA@mail.gmail.com>
Date:	Thu, 11 Jul 2013 09:25:15 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Yuan-Hsin Chen <yhchen@...aday-tech.com>,
	Felipe Balbi <balbi@...com>,
	USB list <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: gadget: fotg210-udc: Remove bogus __init/__exit annotations

On Wed, Jul 10, 2013 at 11:52 PM, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> On 07/11/2013 01:45 AM, Geert Uytterhoeven wrote:
>
>> When builtin (CONFIG_USB_FOTG210_UDC=y):
>
>>    LD      drivers/usb/gadget/built-in.o
>> WARNING: drivers/usb/gadget/built-in.o(.data+0xbf8): Section mismatch in
>> reference from the variable fotg210_driver to the function
>> .init.text:fotg210_udc_probe()
>> The variable fotg210_driver references
>> the function __init fotg210_udc_probe()
>> If the reference is valid then annotate the
>> variable with __init* or __refdata (see linux/init.h) or name the
>> variable:
>> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

>> diff --git a/drivers/usb/gadget/fotg210-udc.c
>> b/drivers/usb/gadget/fotg210-udc.c
>> index cce5535..10cd18d 100644
>> --- a/drivers/usb/gadget/fotg210-udc.c
>> +++ b/drivers/usb/gadget/fotg210-udc.c
>> @@ -1074,7 +1074,7 @@ static struct usb_gadget_ops fotg210_gadget_ops = {
>>         .udc_stop               = fotg210_udc_stop,
>>   };
>>
>> -static int __exit fotg210_udc_remove(struct platform_device *pdev)
>> +static int fotg210_udc_remove(struct platform_device *pdev)
>
>
>    I think you can leave __exit annotation here, if you enclose the
> reference in the driver structure in __exit_p()...

The driver is using module_platform_driver(), not
module_platform_driver_probe(),
so it expects the platform device to show up or disappear anytime.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/