| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 11 Jul 2013 10:46:55 +0100 From: Mel Gorman <mgorman@...e.de> To: Peter Zijlstra <a.p.zijlstra@...llo.nl>, Srikar Dronamraju <srikar@...ux.vnet.ibm.com> Cc: Ingo Molnar <mingo@...nel.org>, Andrea Arcangeli <aarcange@...hat.com>, Johannes Weiner <hannes@...xchg.org>, Linux-MM <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org>, Mel Gorman <mgorman@...e.de> Subject: [PATCH 11/16] sched: Check current->mm before allocating NUMA faults task_numa_placement checks current->mm but after buffers for faults have already been uselessly allocated. Move the check earlier. [peterz@...radead.org: Identified the problem] Signed-off-by: Mel Gorman <mgorman@...e.de> --- kernel/sched/fair.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 0d4e516..54702c9 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -834,8 +834,6 @@ static void task_numa_placement(struct task_struct *p) int seq, nid, max_nid = 0; unsigned long max_faults = 0; - if (!p->mm) /* for example, ksmd faulting in a user's mm */ - return; seq = ACCESS_ONCE(p->mm->numa_scan_seq); if (p->numa_scan_seq == seq) return; @@ -912,6 +910,10 @@ void task_numa_fault(int last_nid, int node, int pages, bool migrated) if (!sched_feat_numa(NUMA)) return; + /* for example, ksmd faulting in a user's mm */ + if (!p->mm) + return; + /* For now, do not attempt to detect private/shared accesses */ priv = 1; -- 1.8.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists