linux-kernel - Re: uefi boot hang (bisected)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 11 Jul 2013 09:57:37 +0800
From:	Dave Young <dyoung@...hat.com>
To:	Matt Fleming <matt.fleming@...el.com>
CC:	lkml <linux-kernel@...r.kernel.org>,
	Matthew Garrett <matthew.garrett@...ula.com>
Subject: Re: uefi boot hang (bisected)

On 07/10/2013 08:36 PM, Matt Fleming wrote:
> On 10/07/13 07:36, Dave Young wrote:
>> Another problem is: With this patch applied I tried noefi boot, but
>> kernel paniced, looks like efivar_init depends on efi runtime. Below
>> patches works for me about noefi boot though I'm not sure if it's a
>> right fix, please review.
> 
> It makes more sense to check in efivars.c, since none of that file can
> function without runtime serivces.
> 
> Could you try the following patch?

It works, thanks for the patch.

Tested-by: Dave Young <dyoung@...hat.com>

> 
> ---
> 
> diff --git a/drivers/firmware/efi/efivars.c b/drivers/firmware/efi/efivars.c
> index 8bd1bb6..8a7432a 100644
> --- a/drivers/firmware/efi/efivars.c
> +++ b/drivers/firmware/efi/efivars.c
> @@ -583,6 +583,9 @@ int efivars_sysfs_init(void)
>  	struct kobject *parent_kobj = efivars_kobject();
>  	int error = 0;
>  
> +	if (!efi_enabled(EFI_RUNTIME_SERVICES))
> +		return -ENODEV;
> +
>  	/* No efivars has been registered yet */
>  	if (!parent_kobj)
>  		return 0;
> 


-- 
Thanks
Dave


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/