linux-kernel - Re: [PATCH] staging: dwc2: fix value used in dwc2_set_all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130711154322.GJ10217@login.drsnuggles.stderr.nl>
Date:	Thu, 11 Jul 2013 17:43:22 +0200
From:	Matthijs Kooijman <matthijs@...in.nl>
To:	Julien Delacou <julien.delacou.st@...il.com>
Cc:	Paul Zimmerman <paulz@...opsys.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Grant Likely <grant.likely@...aro.org>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	devel@...verdev.osuosl.org,
	Julien Delacou <julien.delacou@...ricsson.com>
Subject: Re: [PATCH] staging: dwc2: fix value used in dwc2_set_all_params

On Thu, Jul 11, 2013 at 02:24:10PM +0200, Julien Delacou wrote:
> From: Julien Delacou <julien.delacou@...ricsson.com>
> 
> This fix uses 'value' parameter as it should be instead
> of hardcoded -1.
Woops!

> Signed-off-by: Julien Delacou <julien.delacou@...ricsson.com>
> Acked-by: Paul Zimmerman <paulz@...opys.com>
Reviewed-by: Matthijs Kooijman <matthijs@...in.nl>

> ---
>  drivers/staging/dwc2/hcd.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dwc2/hcd.c b/drivers/staging/dwc2/hcd.c
> index 2ed54b1..ca38aaa 100644
> --- a/drivers/staging/dwc2/hcd.c
> +++ b/drivers/staging/dwc2/hcd.c
> @@ -2690,7 +2690,7 @@ void dwc2_set_all_params(struct dwc2_core_params *params, int value)
>  	int i;
>  
>  	for (i = 0; i < size; i++)
> -		p[i] = -1;
> +		p[i] = value;
>  }
>  EXPORT_SYMBOL_GPL(dwc2_set_all_params);
>  
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/