linux-kernel - RE: [Intel-gift] Linux 3.10-rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B028E6200@HASMSX106.ger.corp.intel.com>
Date:	Thu, 11 Jul 2013 19:52:14 +0000
From:	"Winkler, Tomas" <tomas.winkler@...el.com>
To:	Shuah Khan <shuah.kh@...sung.com>
CC:	Daniel Vetter <daniel.vetter@...ll.ch>,
	intel-gfx <intel-gfx@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"shuahkhan@...il.com" <shuahkhan@...il.com>,
	Dave Airlie <airlied@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"rjw@...k.pl" <rjw@...k.pl>,
	"shuahkhan@...il.com" <shuahkhan@...il.com>
Subject: RE: [Intel-gift] Linux 3.10-rc7


> I don't see mei_me_pci_suspend() calling mei_disable_interrupts() and
> pci_disable_msi().

Suspend calls mei_reset with request for disabling interrupts  
I'm pretty sure I do free_irq and I do disable_msi in the suspend (Hope we are looking at the same code)

 I don't see a call to mei_enable_interrupts() from
> mei_me_pci_resume(). I don't think mei_enable_interrupts() is used
> anywhere. pci_dev_msi_enabled() enables the interrupts in
> mei_me_pci_resume() looks like.

Again here we call mei_reset with request of enabling the interrupts 

> 
> However, I did notice one thing, if pci_dev_msi_enabled() returns false,
> request_threaded_irq() is called  with IRQF_SHARED. Again might just be
> fine, it leads me to the next question.
>

Is the MSI disabled on  your platform? 
 
> mei_me_pci_suspend() has code that runs after disabling interrupts. Does
> this need to be split into suspend() and suspend_noirq() ops, since the IRQ
> could be shared?

If you don't have msi 
I think usually it is shared with some USB device, but I haven't seen that in my code I will check again.
Would other resume block the interrupt line?
 
> It is a possibility if pci_enable_msi() takes longer in resume path and
> pci_dev_msi_enabled() returns false, then IRQF_SHARED is requested.
> 
> Don't know if this helpful, but I thought I would ask just in case, it helps you
> think of something you didn't before. Please let me know if you need help
> gathering data from my system.

Thanks for ideas I will check that points.

Thanks
Tomas

> -- Shuah
> 
> Shuah Khan, Linux Kernel Developer - Open Source Group Samsung Research
> America (Silicon Valley) shuah.kh@...sung.com | (970) 672-0658
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/