[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20130711152006.de0900cfcd784f2833285ee4@linux-foundation.org>
Date: Thu, 11 Jul 2013 15:20:06 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: David Rientjes <rientjes@...gle.com>
Cc: Oleg Nesterov <oleg@...hat.com>,
KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
Mel Gorman <mgorman@...e.de>, Rik van Riel <riel@...hat.com>,
Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: mempolicy: turn vma_set_policy() into
vma_dup_policy()
On Thu, 11 Jul 2013 15:13:03 -0700 (PDT) David Rientjes <rientjes@...gle.com> wrote:
> > +int vma_dup_policy(struct vm_area_struct *src, struct vm_area_struct *dst)
> > +{
> > + struct mempolicy *pol = mpol_dup(vma_policy(src));
> > +
> > + if (IS_ERR(pol))
> > + return PTR_ERR(pol);
>
> PTR_ERR() returns long, so vma_dup_policy() needs to return long.
hm, really? vma_dup_policy() returns an errno and errnos have type "int".
Arguably it is PTR_ERR() which returns the wrong type...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists