linux-kernel - Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51DF44FA.9060000@asianux.com>
Date:	Fri, 12 Jul 2013 07:51:22 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	Frederic Weisbecker <fweisbec@...il.com>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function()
 and trace_selftest_startup_function_graph()

On 07/12/2013 12:47 AM, Steven Rostedt wrote:
> On Thu, 2013-07-11 at 08:31 +0800, Chen Gang wrote:
>> Like other trace_selftest_startup_*, trace_selftest_startup_function()
>> and trace_selftest_startup_function_graph() need in normal section, or
>> may cause section mismatch.
>>
>> The related warnings:
>>
>>     LD      kernel/trace/built-in.o
>>   WARNING: kernel/trace/built-in.o(.data+0x154c): Section mismatch in reference from the variable function_trace to the function .init.text:trace_selftest_startup_function()
>>   The variable function_trace references
>>   the function __init trace_selftest_startup_function()
>>   If the reference is valid then annotate the
>>   variable with __init* or __refdata (see linux/init.h) or name the variable:
>>   *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
>>
> 
> No the fix is to add ref_data to the user. The selftest are only called
> at boot up. No need to waste memory keeping them around.
> 

Ok, thanks.

Hmm, can all trace_selftest_startup_* (*selftest* in trace_selftest.c)
use '__init', so not waste memory keeping them around ?


Thanks.
-- 
Chen Gang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/