lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 Jul 2013 10:39:18 +0300 From: Alexander Shishkin <alexander.shishkin@...ux.intel.com> To: Alan Stern <stern@...land.harvard.edu>, Geert Uytterhoeven <geert@...ux-m68k.org> Cc: Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Felipe Balbi <balbi@...com>, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 6/6] [RFC] usb: gadget: USB_GADGET should depend on HAS_DMA Alan Stern <stern@...land.harvard.edu> writes: > On Thu, 11 Jul 2013, Geert Uytterhoeven wrote: > >> If NO_DMA=y: >> >> drivers/built-in.o: In function `dma_set_coherent_mask': >> include/linux/dma-mapping.h:93: undefined reference to `dma_supported' >> include/linux/dma-mapping.h:93: undefined reference to `dma_supported' >> drivers/built-in.o: In function `usb_gadget_unmap_request': >> drivers/usb/gadget/udc-core.c:91: undefined reference to `dma_unmap_sg' >> drivers/usb/gadget/udc-core.c:96: undefined reference to `dma_unmap_single' >> drivers/built-in.o: In function `usb_gadget_map_request': >> drivers/usb/gadget/udc-core.c:62: undefined reference to `dma_map_sg' >> drivers/usb/gadget/udc-core.c:71: undefined reference to `dma_map_single' >> drivers/usb/gadget/udc-core.c:74: undefined reference to `dma_mapping_error' >> >> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org> >> --- >> This one is very debatable: probably the parts using the DMA API should >> be factored out, instead of disabling the whole USB gadget subsystem. > > Indeed. How does this look instead? This one is much better. FWIW, Acked-by: Alexander Shishkin <alexander.shishkin@...ux.intel.com> Regards, -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists