linux-kernel - Re: [PATCH] x86/pci: fix checkpatch.pl indentation warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130712102641.GA13675@gmail.com>
Date:	Fri, 12 Jul 2013 12:26:41 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Valentina Manea <valentina.manea.m@...il.com>
Cc:	x86@...nel.org, tglx@...utronix.de, mingo@...hat.com,
	hpa@...or.com, bhelgaas@...gle.com, gregkh@...uxfoundation.org,
	bin.gao@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/pci: fix checkpatch.pl indentation warnings


* Valentina Manea <valentina.manea.m@...il.com> wrote:

> This patch fixes warnings generated by checkpatch.pl
> regarding indentation.
> 
> Signed-off-by: Valentina Manea <valentina.manea.m@...il.com>
> ---
>  arch/x86/pci/mrst.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/pci/mrst.c b/arch/x86/pci/mrst.c
> index 6eb18c4..cd0a373 100644
> --- a/arch/x86/pci/mrst.c
> +++ b/arch/x86/pci/mrst.c
> @@ -251,8 +251,8 @@ static void pci_d3delay_fixup(struct pci_dev *dev)
>  {
>  	/* PCI fixups are effectively decided compile time. If we have a dual
>  	   SoC/non-SoC kernel we don't want to mangle d3 on non SoC devices */
> -        if (!pci_soc_mode)
> -            return;
> +	if (!pci_soc_mode)
> +		return;
>  	/* true pci devices in lincroft should allow type 1 access, the rest
>  	 * are langwell fake pci devices.
>  	 */

If you do whitespace cleanups then please also fix all the other problems 
in that file, right now mrst.c has more than just one:

  total: 3 errors, 7 warnings, 3 checks, 303 lines checked

plus the area you patched has some wierd comment formatting as well. For 
multi-line comments we use:

  /*
   * Comment .....
   * ...... goes here.
   */

as specified in Documentation/CodingStyle.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/