linux-kernel - Re: [PATCH] ACPI / memhotplug: Fix a stale pointer in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Jul 2013 08:51:29 -0600
From:	Toshi Kani <toshi.kani@...com>
To:	Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>
Cc:	rjw@...k.pl, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI / memhotplug: Fix a stale pointer in error path

On Fri, 2013-07-12 at 09:24 +0900, Yasuaki Ishimatsu wrote:
> (2013/07/11 1:47), Toshi Kani wrote:
> > device->driver_data needs to be cleared when releasing its data,
> > mem_device, in an error path of acpi_memory_device_add().
> > 
> > Signed-off-by: Toshi Kani <toshi.kani@...com>
> > ---
> 
> Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>

Thanks Yasuaki!
-Toshi



> 
> Thanks,
> Yasuaki Ishimatsu
> 
> >   drivers/acpi/acpi_memhotplug.c |    1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
> > index c711d11..999adb5 100644
> > --- a/drivers/acpi/acpi_memhotplug.c
> > +++ b/drivers/acpi/acpi_memhotplug.c
> > @@ -323,6 +323,7 @@ static int acpi_memory_device_add(struct acpi_device *device,
> >   	/* Get the range from the _CRS */
> >   	result = acpi_memory_get_device_resources(mem_device);
> >   	if (result) {
> > +		device->driver_data = NULL;
> >   		kfree(mem_device);
> >   		return result;
> >   	}
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/