linux-kernel - Re: [PATCH 3/3] pch_gbe: Add MinnowBoard support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130713011731.GA17939@kroah.com>
Date:	Fri, 12 Jul 2013 18:17:31 -0700
From:	Greg KH <greg@...ah.com>
To:	Darren Hart <dvhart@...ux.intel.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	"H. Peter Anvin" <hpa@...or.com>,
	Peter Waskiewicz <peter.p.waskiewicz.jr@...el.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	netdev@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 3/3] pch_gbe: Add MinnowBoard support

On Fri, Jul 12, 2013 at 05:58:07PM -0700, Darren Hart wrote:
> The MinnowBoard uses an AR803x PHY with the PCH GBE which requires
> special handling. Use the MinnowBoard PCI Subsystem ID to detect this
> and add a pci_device_id.driver_data structure and functions to handle
> platform setup.
> 
> The AR803x does not implement the RGMII 2ns TX clock delay in the trace
> routing nor via strapping. Add a detection method for the board and the
> PHY and enable the TX clock delay via the registers.
> 
> This PHY will hibernate without link for 10 seconds. Ensure the PHY is
> awake for probe and then disable hibernation. A future improvement would
> be to convert pch_gbe to using PHYLIB and making sure we can wake the
> PHY at the necessary times rather than permanently disabling it.
> 
> Signed-off-by: Darren Hart <dvhart@...ux.intel.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: Peter Waskiewicz <peter.p.waskiewicz.jr@...el.com>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: netdev@...r.kernel.org
> Cc: <stable@...r.kernel.org> # 3.8.x: 5829e9b mfd: lpc_sch: Accomodate partial
> Cc: <stable@...r.kernel.org> # 3.8.x: 3cbf182 gpio-sch: Allow for more than 8
> Cc: <stable@...r.kernel.org> # 3.8.x: 91bbe92: PCI: Add CircuitCo vendor ID
> Cc: <stable@...r.kernel.org> # 3.8.x: bd79680: pch_gbe: remove inline keyword
> Cc: <stable@...r.kernel.org> # 3.8.x: 453ca93: pch_gbe: convert pr_* to
> Cc: <stable@...r.kernel.org> # 3.8.x: 29cc436: pch_gbe: use managed functions
> Cc: <stable@...r.kernel.org> # 3.8.x
> Cc: <stable@...r.kernel.org> # 3.10.x: 91bbe92: PCI: Add CircuitCo vendor ID
> Cc: <stable@...r.kernel.org> # 3.10.x: bd79680: pch_gbe: remove inline keyword
> Cc: <stable@...r.kernel.org> # 3.10.x: 453ca93: pch_gbe: convert pr_* to
> Cc: <stable@...r.kernel.org> # 3.10.x: 29cc436: pch_gbe: use managed functions
> Cc: <stable@...r.kernel.org> # 3.10.x
> Signed-off-by: Darren Hart <dvhart@...ux.intel.com>
> ---
>  drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h    | 15 ++++
>  .../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c   | 48 +++++++++++
>  .../net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c    | 98 ++++++++++++++++++++++
>  .../net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.h    |  2 +
>  4 files changed, 163 insertions(+)

This is _far_ more than just a simple "add a new device id" for a stable
kernel update.   Please go read Documentation/stable_kernel_rules.txt
again for why there's no way I can take this type of thing.

You know better than this.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/