linux-kernel - Re: [PATCH] staging/lustre/libcfs: replaced string duplication code with kstrdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CE0749B3.54CC0%andreas.dilger@intel.com>
Date:	Sun, 14 Jul 2013 00:20:05 +0000
From:	"Dilger, Andreas" <andreas.dilger@...el.com>
To:	Dragos Foianu <dragos.foianu@...il.com>
CC:	"tao.peng@....com" <tao.peng@....com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging/lustre/libcfs: replaced string duplication code
 with kstrdup

On 2013/12/07 1:02 AM, "Dragos Foianu" <dragos.foianu@...il.com> wrote:

>Modified cfs_strdup function to use kstrdup instead of duplicating its
>implementation.
>
>Found using Coccinelle.

Thanks for the patch, but in fact this function doesn't appear to be used
in the code anymore and could be removed entirely.  Seems that
cfs_vsnprintf() and cfs_snprintf() could also be deleted at the same time.

Cheers, Andreas

>Signed-off-by: Dragos Foianu <dragos.foianu@...il.com>
>---
> drivers/staging/lustre/lustre/libcfs/libcfs_string.c |   13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
>diff --git a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
>b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
>index 9edccc9..4dba304 100644
>--- a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
>+++ b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
>@@ -135,18 +135,7 @@ EXPORT_SYMBOL(cfs_str2mask);
> /* Duplicate a string in a platform-independent way */
> char *cfs_strdup(const char *str, u_int32_t flags)
> {
>-	size_t lenz; /* length of str + zero byte */
>-	char *dup_str;
>-
>-	lenz = strlen(str) + 1;
>-
>-	dup_str = kmalloc(lenz, flags);
>-	if (dup_str == NULL)
>-		return NULL;
>-
>-	memcpy(dup_str, str, lenz);
>-
>-	return dup_str;
>+	return kstrdup(str, flags);
> }
> EXPORT_SYMBOL(cfs_strdup);


Cheers, Andreas
-- 
Andreas Dilger

Lustre Software Architect
Intel High Performance Data Division


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/