linux-kernel - Re: [PATCH] ASoC: kirkwood-i2s: fix a compilation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130715153101.GK11538@sirena.org.uk>
Date:	Mon, 15 Jul 2013 16:31:01 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Jean-Francois Moine <moinejf@...e.fr>
Cc:	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	Liam Girdwood <lgirdwood@...il.com>,
	Russell King <rmk+kernel@....linux.org.uk>
Subject: Re: [PATCH] ASoC: kirkwood-i2s: fix a compilation warning

On Mon, Jul 15, 2013 at 10:36:44AM +0200, Jean-Francois Moine wrote:
> In the function kirkwood_set_rate, when the rate cannot be satisfied
> by the internal nor by an external clock, the clock source in undefined:

>  warning: ‘clks_ctrl’ may be used uninitialized in this function

> As the ALSA subsystem should never gives such a rate, this patch removes
> the check of the external clock pointer.

> -	} else if (!IS_ERR(priv->extclk)) {
> +	} else {

I'd really like to see an analysis explaining why this can never happen,
the driver explicitly supports running without extclk being provided.
Simply asserting that we should never get such a rate isn't really
enough detail...

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)