linux-kernel - Re: [PATCH v2] lib: One less subtraction in binary search iterations.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ehb01kdy.fsf@rustcorp.com.au>
Date:	Mon, 15 Jul 2013 14:37:21 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Wedson Almeida Filho <wedsonaf@...il.com>,
	Joe Perches <joe@...ches.com>
Cc:	Tim Abbott <tabbott@...lice.com>, linux-kernel@...r.kernel.org,
	Wedson Almeida Filho <wedsonaf@...il.com>
Subject: Re: [PATCH v2] lib: One less subtraction in binary search iterations.

Wedson Almeida Filho <wedsonaf@...il.com> writes:
> The subtraction is removed at the expense of generality: when the element size
> is 1, the array length cannot exceed half the architecture's addressable
> memory.

People do copy code, so I prefer to set the best example possible.

Unless it's a useful optimization, I think it should stay the way it is.

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/