linux-kernel - Re: [PATCH] ASoC: kirkwood-i2s: fix a compilation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Jul 2013 22:37:27 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Mark Brown <broonie@...nel.org>
Cc:	Jean-Francois Moine <moinejf@...e.fr>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH] ASoC: kirkwood-i2s: fix a compilation warning

On Mon, Jul 15, 2013 at 09:08:51PM +0100, Mark Brown wrote:
> There's no obvious code that handles anything differently with extclk.
> Indeed if you think about it for a minute you'll realise there's no way
> the driver will ever use an extclk - set_rate() is badly implemented,
> look at how other drivers select between clocks.

I suggest you go back and re-read the driver because it most certainly
does use extclk.  What makes you think it won't?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/