lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-id: <000101ce812a$dec735d0$9c55a170$@samsung.com>
Date:	Mon, 15 Jul 2013 16:13:56 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Yijing Wang' <wangyijing@...wei.com>,
	'Jean-Christophe Plagniol-Villard' <plagnioj@...osoft.com>,
	'Tomi Valkeinen' <tomi.valkeinen@...com>
Cc:	linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org,
	'Hanjun Guo' <guohanjun@...wei.com>, jiang.liu@...wei.com,
	Jingoo Han <jg1.han@...sung.com>
Subject: Re: [PATCH] video: remove unused variable "dev" in vga16fb_destroy()

On Monday, July 15, 2013 3:29 PM, Yijing Wang wrote:
> 
> Delete unused variable "dev" to fix build warning in
> drivers/video/vga16fb.c
> 
> Signed-off-by: Yijing Wang <wangyijing@...wei.com>
> Cc: Jingoo Han <jg1.han@...sung.com>

It looks good.
Reviewed-by: Jingoo Han <jg1.han@...sung.com>

Best regards,
Jingoo Han

> ---
>  drivers/video/vga16fb.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
> index 830ded4..2827333 100644
> --- a/drivers/video/vga16fb.c
> +++ b/drivers/video/vga16fb.c
> @@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
> 
>  static void vga16fb_destroy(struct fb_info *info)
>  {
> -	struct platform_device *dev = container_of(info->device, struct platform_device, dev);
>  	iounmap(info->screen_base);
>  	fb_dealloc_cmap(&info->cmap);
>  	/* XXX unshare VGA regions */
> --
> 1.7.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ