linux-kernel - Re: [PATCH 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <51E668B4.1010000@ti.com>
Date:	Wed, 17 Jul 2013 12:49:40 +0300
From:	Oleksandr Kozaruk <oleksandr.kozaruk@...com>
To:	Jonathan Cameron <jic23@...nel.org>
CC:	<tony@...mide.com>, <benoit.cousson@...aro.org>, <rnayak@...com>,
	<peter.ujfalusi@...com>, <kishon@...com>, <jic23@....ac.uk>,
	<grant.likely@...aro.org>, <rob.herring@...xeda.com>,
	<lars@...afoo.de>, <sameo@...ux.intel.com>,
	<ch.naveen@...sung.com>, <poeschel@...onage.de>, <milo.kim@...com>,
	<balajitk@...com>, <gg@...mlogic.co.uk>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <linux-iio@...r.kernel.org>,
	<devicetree-discuss@...ts.ozlabs.org>, <linux-omap@...r.kernel.org>
Subject: Re: [PATCH 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver

Hello Jonathan,

 >Two very quick comments based on quick glance as it may be a while 
before I can do a full review.

 >We still have channels that are only usable for temperature being 
output to user space as voltage channels? Is the conversion so very hard?

Can you please clarify what should return temperature channel for 
in_tempX_input (processed)? Is it voltage or Celsius degree?
in_tempX_raw should return ADC code? Right?

Regards,
OK.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/