linux-kernel - Re: [PATCH] timer stats: reset entries when disable the timer usage statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130717095840.GL27577@zhudong.nay.redhat.com>
Date:	Wed, 17 Jul 2013 17:58:40 +0800
From:	Dong Zhu <bluezhudong@...il.com>
To:	John Stultz <john.stultz@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] timer stats: reset entries when disable the timer
 usage statistics

On Thu, Jun 20, 2013 at 06:30:48PM +0800, Dong Zhu wrote:
> On Mon, Jun 10, 2013 at 03:57:45PM +0800, Dong Zhu wrote:
> > From 4dbb760213856dc382241db456c1c6487694837c Mon Sep 17 00:00:00 2001
> > From: Dong Zhu <bluezhudong@...il.com>
> > Date: Mon, 10 Jun 2013 15:09:27 +0800
> > 
> > we can start/stop data collection by using :
> > echo [1|0] > /proc/timer_stats
> > when we stop the data collection,hrtimer will not update the statistics
> > for a timer any more,but we could still check the timer usage
> > statistics,unfortunately the data is not the latest, the inaccurate data
> > might make us confusing. So the purpose of this patch is to reset the
> > entries once disable operation is executed.In this way we will never
> > see the inaccurate timer usage statistics.
> > 
> > Signed-off-by: Dong Zhu <bluezhudong@...il.com>
> > ---
> >  kernel/time/timer_stats.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/kernel/time/timer_stats.c b/kernel/time/timer_stats.c
> > index 0b537f2..43f05e7 100644
> > --- a/kernel/time/timer_stats.c
> > +++ b/kernel/time/timer_stats.c
> > @@ -371,6 +371,7 @@ static ssize_t tstats_write(struct file *file, const char __user *buf,
> >  	switch (ctl[0]) {
> >  	case '0':
> >  		if (timer_stats_active) {
> > +			reset_entries();
> >  			timer_stats_active = 0;
> >  			time_stop = ktime_get();
> >  			sync_access();
> > -- 
> > 1.7.11.7
> 

Hi John and Thomas,

A long time has passed and still no reply here. I think this patch makes sense
so could you plz accept it ? Thanks!

BTW, any comments would be appreciated.

-- 
Best Regards,
Dong Zhu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/