linux-kernel - Re: [PATCH 1/2] mfd: wm8994: Remove duplicate check for active JACKDET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130717115249.GE3336@laptop>
Date:	Wed, 17 Jul 2013 12:52:49 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Mark Brown <broonie@...nel.org>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org,
	Mark Brown <broonie@...aro.org>
Subject: Re: [PATCH 1/2] mfd: wm8994: Remove duplicate check for active
 JACKDET

On Wed, 17 Jul 2013, Mark Brown wrote:

> From: Mark Brown <broonie@...aro.org>
> 
> Probably the result of a mismerge or rebase failing to notice that the
> hunk had already been applied.
> 
> Signed-off-by: Mark Brown <broonie@...aro.org>
> ---
>  drivers/mfd/wm8994-core.c | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/mfd/wm8994-core.c b/drivers/mfd/wm8994-core.c
> index 781115e..e8ecb8e 100644
> --- a/drivers/mfd/wm8994-core.c
> +++ b/drivers/mfd/wm8994-core.c
> @@ -245,20 +245,6 @@ static int wm8994_suspend(struct device *dev)
>  		break;
>  	}
>  
> -	switch (wm8994->type) {
> -	case WM1811:
> -		ret = wm8994_reg_read(wm8994, WM8994_ANTIPOP_2);
> -		if (ret < 0) {
> -			dev_err(dev, "Failed to read jackdet: %d\n", ret);
> -		} else if (ret & WM1811_JACKDET_MODE_MASK) {
> -			dev_dbg(dev, "CODEC still active, ignoring suspend\n");
> -			return 0;
> -		}
> -		break;
> -	default:
> -		break;
> -	}
> -
>  	/* Disable LDO pulldowns while the device is suspended if we
>  	 * don't know that something will be driving them. */
>  	if (!wm8994->ldo_ena_always_driven)

I don't see the duplicate?

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/