linux-kernel - Re: [PATCH] mlx5: qp: variable may be used uninitialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130717160604.GG21894@mtldesk30>
Date:	Wed, 17 Jul 2013 19:06:04 +0300
From:	Eli Cohen <eli@....mellanox.co.il>
To:	Andi Shyti <andi@...zian.org>
Cc:	eli@...lanox.com, roland@...nel.org, sean.hefty@...el.com,
	hal.rosenstock@...il.com, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mlx5: qp: variable may be used uninitialized

Acked-by: Eli Cohen <eli@...lanox.com>

On Tue, Jul 16, 2013 at 03:35:01PM +0200, Andi Shyti wrote:
> in the sq_overhead() function, if qp_typ is equal to IB_QPT_RC,
> size will be used uninitialized.
> 
> Signed-off-by: Andi Shyti <andi@...zian.org>
> ---
>  drivers/infiniband/hw/mlx5/qp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
> index 16ac54c..045f8cd 100644
> --- a/drivers/infiniband/hw/mlx5/qp.c
> +++ b/drivers/infiniband/hw/mlx5/qp.c
> @@ -199,7 +199,7 @@ static int set_rq_size(struct mlx5_ib_dev *dev, struct ib_qp_cap *cap,
>  
>  static int sq_overhead(enum ib_qp_type qp_type)
>  {
> -	int size;
> +	int size = 0;
>  
>  	switch (qp_type) {
>  	case IB_QPT_XRC_INI:
> -- 
> 1.8.3.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/