linux-kernel - RE: [PATCH v2] RDMA/cma: silence GCC warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1828884A29C6694DAF28B7E6B8A82373805B8318@ORSMSX109.amr.corp.intel.com>
Date:	Wed, 17 Jul 2013 18:07:17 +0000
From:	"Hefty, Sean" <sean.hefty@...el.com>
To:	Paul Bolle <pebolle@...cali.nl>, Roland Dreier <roland@...nel.org>,
	"Hal Rosenstock" <hal.rosenstock@...il.com>
CC:	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] RDMA/cma: silence GCC warning

> Building cma.o triggers this GCC warning:
>     drivers/infiniband/core/cma.c: In function ‘rdma_resolve_addr’:
>     drivers/infiniband/core/cma.c:465:23: warning: ‘port’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
>     drivers/infiniband/core/cma.c:426:5: note: ‘port’ was declared here
> 
> This is a false positive, as "port" will always be initialized if we're
> at "found". But if we assign to "id_priv->id.port_num" directly, we can
> drop "port". That will, obviously, silence GCC.
> 
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>

Acked-by: Sean Hefty <sean.hefty@...el.com>

> ---
> 0) v2: assign to "id_priv->id.port_num" directly, instead of
> initializing "port" to 0, as discussed with Sean.
> 
> 1) Still only compile tested.

tested - thanks